[DTrace-devel] [PATCH] The printf action without conversions was not getting printed

[Eugene Loh]

Thanks for the quick fix.

I agree with the fix.

I do think the variations in nomenclature are unneeded. Specifically, 
the actual fix speaks in terms of "arguments".  In contrast, the commit 
title line and the test names refer to "conversions".  I understand the 
relationship, but I think it makes more sense for the title line and 
test names to refer to the actual source code.  And the term "arguments" 
is perfectly sensible for a printf(format, arg1, arg2, arg3) user.  The 
number of conversions doesn't really have much to do with anything -- 
except indirectly in that DTrace checks that the number of conversions 
and of arguments agree.

And...

On 06/18/2020 06:51 PM, Kris Van Hees wrote:
> diff --git a/test/unittest/actions/printf/tst.no-conv.only.d 
> b/test/unittest/actions/printf/tst.no-conv.only.d
> + * ASSERTION: The printf action supports a constant format string without
> + *	      conversions, when it is the first only.
s/first only/only action/