[DTrace-devel] [PATCH 3/5] Other provider cleanup

[Kris Van Hees]

On Thu, Jun 11, 2020 at 05:29:39PM -0400, eugene.loh at oracle.com wrote:
> From: Eugene Loh <eugene.loh at oracle.com>
> 
> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

> ---
>  libdtrace/dt_cg.c           | 4 ++--
>  libdtrace/dt_prov_dtrace.c  | 4 ++--
>  libdtrace/dt_prov_fbt.c     | 4 ++--
>  libdtrace/dt_prov_sdt.c     | 4 ++--
>  libdtrace/dt_prov_syscall.c | 4 ++--
>  5 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/libdtrace/dt_cg.c b/libdtrace/dt_cg.c
> index 34342f44..37c8d25c 100644
> --- a/libdtrace/dt_cg.c
> +++ b/libdtrace/dt_cg.c
> @@ -29,8 +29,8 @@ static void dt_cg_node(dt_node_t *, dt_irlist_t *, dt_regset_t *);
>   *	1. Store ctx (%r1) in its reserved stack slot
>   *	2. Store dctx (%r2) in its reserved stack slot
>   *	3. Evaluate the predicate expression and exit if false
> - *	5. Retrieve the output data buffer and store the base pointer in %r9
> - *	6. Store a 4-byte 0 value at [%r9 + 4], and advance %r9 by 4 bytes
> + *	4. Retrieve the output data buffer and store the base pointer in %r9
> + *	5. Store a 4-byte 0 value at [%r9 + 4], and advance %r9 by 4 bytes
>   *	6. Store the epid and tag at [%r9 + 0] and [%r9 + 4] respectively
>   *
>   * Due to the fact that raw perf samples are stored as a header (multiple of 8
> diff --git a/libdtrace/dt_prov_dtrace.c b/libdtrace/dt_prov_dtrace.c
> index 507aa60f..fe9759de 100644
> --- a/libdtrace/dt_prov_dtrace.c
> +++ b/libdtrace/dt_prov_dtrace.c
> @@ -149,8 +149,8 @@ static void trampoline(dt_pcb_t *pcb)
>  
>  	/*
>  	 * We know the BPF context (regs) is in %r1.  Since we will be passing
> -	 * the DTrace context (dctx) as 2nd argument to dt_predicate() (if
> -	 * there is a predicate) and dt_program, we need it in %r2.
> +	 * the DTrace context (dctx) as 2nd argument to dt_program, we need it
> +	 * in %r2.
>  	 */
>  	instr = BPF_MOV_REG(BPF_REG_2, BPF_REG_FP);
>  	dt_irlist_append(dlp, dt_cg_node_alloc(DT_LBL_NONE, instr));
> diff --git a/libdtrace/dt_prov_fbt.c b/libdtrace/dt_prov_fbt.c
> index 2296fb41..1aa3ca3c 100644
> --- a/libdtrace/dt_prov_fbt.c
> +++ b/libdtrace/dt_prov_fbt.c
> @@ -246,8 +246,8 @@ static void trampoline(dt_pcb_t *pcb)
>  
>  	/*
>  	 * We know the BPF context (regs) is in %r1.  Since we will be passing
> -	 * the DTrace context (dctx) as 2nd argument to dt_predicate() (if
> -	 * there is a predicate) and dt_program, we need it in %r2.
> +	 * the DTrace context (dctx) as 2nd argument to dt_program, we need it
> +	 * in %r2.
>  	 */
>  	instr = BPF_MOV_REG(BPF_REG_2, BPF_REG_FP);
>  	dt_irlist_append(dlp, dt_cg_node_alloc(DT_LBL_NONE, instr));
> diff --git a/libdtrace/dt_prov_sdt.c b/libdtrace/dt_prov_sdt.c
> index 380a1ef8..6d99653a 100644
> --- a/libdtrace/dt_prov_sdt.c
> +++ b/libdtrace/dt_prov_sdt.c
> @@ -353,8 +353,8 @@ static void trampoline(dt_pcb_t *pcb)
>  
>  	/*
>  	 * We know the BPF context (scd) is in %r1.  Since we will be passing
> -	 * the DTrace context (dctx) as 2nd argument to dt_predicate() (if
> -	 * there is a predicate) and dt_program, we need it in %r2.
> +	 * the DTrace context (dctx) as 2nd argument to dt_program, we need it
> +	 * in %r2.
>  	 */
>  	instr = BPF_MOV_REG(BPF_REG_2, BPF_REG_FP);
>  	dt_irlist_append(dlp, dt_cg_node_alloc(DT_LBL_NONE, instr));
> diff --git a/libdtrace/dt_prov_syscall.c b/libdtrace/dt_prov_syscall.c
> index 8f671f38..0b0ca954 100644
> --- a/libdtrace/dt_prov_syscall.c
> +++ b/libdtrace/dt_prov_syscall.c
> @@ -208,8 +208,8 @@ static void trampoline(dt_pcb_t *pcb)
>  
>  	/*
>  	 * We know the BPF context (scd) is in %r1.  Since we will be passing
> -	 * the DTrace context (dctx) as 2nd argument to dt_predicate() (if
> -	 * there is a predicate) and dt_program, we need it in %r2.
> +	 * the DTrace context (dctx) as 2nd argument to dt_program, we need it
> +	 * in %r2.
>  	 */
>  	instr = BPF_MOV_REG(BPF_REG_2, BPF_REG_FP);
>  	dt_irlist_append(dlp, dt_cg_node_alloc(DT_LBL_NONE, instr));
> -- 
> 2.18.2
> 
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel