[DTrace-devel] [PATCH 13/13] Eliminate deadman references

[Kris Van Hees]

On Wed, Jul 01, 2020 at 10:41:18PM -0400, eugene.loh at oracle.com wrote:
> From: Eugene Loh <eugene.loh at oracle.com>
> 
> The deadman support was in the kernel patches for DTrace v1.
> It is not in this version.

This is a premature conclusion.  We may vrey well implement the same in DTrace
v2 to report systemic unresponsiveness which could be an indication of kernel
level issues disrupting DTrace's operation - e.g. a deadlock somewhere causing
probes to not fire.

For now, let's keep this code where it is.

> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
> ---
>  runtest.sh               | 14 --------------
>  test/stress/test.options |  1 -
>  2 files changed, 15 deletions(-)
> 
> diff --git a/runtest.sh b/runtest.sh
> index ad579ef1..e0a32a33 100755
> --- a/runtest.sh
> +++ b/runtest.sh
> @@ -797,10 +797,6 @@ for dt in $dtrace; do
>          # @@timeout-success: If present, this means that a timeout is
>          #                    considered a test pass, not a test failure.
>          #
> -        # @@deadman-success: If present, this means that a deadman timer
> -        #                    firing is considered a test pass, not a test
> -        #                    failure.
> -        #
>          # @@reinvoke-failure: If present, this is an integer indicating the
>          #                     number of times to reinvoke failed tests: only
>          #                     if they fail every time will they be considered
> @@ -1249,16 +1245,6 @@ for dt in $dtrace; do
>                  fi
>              fi
>  
> -            # If deadman-success is on, then a deadman timer firing turns
> -            # a test into an XFAIL.
> -            if grep -q "Abort due to systemic unresponsiveness" $testerr &&
> -                [[ "x$(extract_options deadman-success $_test)" != "x" ]]; then
> -                testmsg="(expected) systemic unresponsiveness"
> -                if [[ $expected_exitcode -eq 0 ]]; then
> -                    xfail=t
> -                fi
> -            fi
> -
>              # If we are expecting a specific tag in the error output, make sure
>              # it is present.  If found, we clear expected_tag to signal that
>              # all is fine.
> diff --git a/test/stress/test.options b/test/stress/test.options
> index 6a8d6b39..7d17d0f5 100644
> --- a/test/stress/test.options
> +++ b/test/stress/test.options
> @@ -1,3 +1,2 @@
>  @@timeout: 600
>  @@timeout-success: t
> -@@deadman-success: t
> -- 
> 2.18.2
> 
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel