[DTrace-devel] [PATCH 15/15] Remove @@xfail marker for tests that should pass now

Kris Van Hees kris.van.hees at oracle.com
Wed Dec 9 11:25:35 PST 2020


With the implementation of basic aggregation support and the printa()
action, more tests should now be able to pass.

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
---
 test/unittest/aggs/tst.allquant.d         | 1 -
 test/unittest/aggs/tst.avg.d              | 4 +---
 test/unittest/aggs/tst.avg_neg.d          | 4 +---
 test/unittest/aggs/tst.llquantincr.d      | 5 +----
 test/unittest/aggs/tst.llquantize.d       | 5 +----
 test/unittest/aggs/tst.llquantneg.d       | 5 +----
 test/unittest/aggs/tst.llquantoverflow.d  | 5 +----
 test/unittest/aggs/tst.llquantround.d     | 2 --
 test/unittest/aggs/tst.max.d              | 5 +----
 test/unittest/aggs/tst.max_neg.d          | 5 +----
 test/unittest/aggs/tst.min.d              | 5 +----
 test/unittest/aggs/tst.min_neg.d          | 5 +----
 test/unittest/aggs/tst.multiaggs2.d       | 5 +----
 test/unittest/aggs/tst.quantlast.d        | 5 +----
 test/unittest/aggs/tst.quantround.d       | 1 -
 test/unittest/aggs/tst.stddev.d           | 4 +---
 test/unittest/aggs/tst.sum.d              | 4 +---
 test/unittest/printa/tst.walltimestamp.sh | 1 -
 18 files changed, 14 insertions(+), 57 deletions(-)

diff --git a/test/unittest/aggs/tst.allquant.d b/test/unittest/aggs/tst.allquant.d
index aa59b469..d10b0b4d 100644
--- a/test/unittest/aggs/tst.allquant.d
+++ b/test/unittest/aggs/tst.allquant.d
@@ -4,7 +4,6 @@
  * Licensed under the Universal Permissive License v 1.0 as shown at
  * http://oss.oracle.com/licenses/upl.
  */
-/* @@xfail: dtv2 */
 
 #pragma D option quiet
 
diff --git a/test/unittest/aggs/tst.avg.d b/test/unittest/aggs/tst.avg.d
index 4e86be39..68cf18a9 100644
--- a/test/unittest/aggs/tst.avg.d
+++ b/test/unittest/aggs/tst.avg.d
@@ -4,11 +4,9 @@
  * Licensed under the Universal Permissive License v 1.0 as shown at
  * http://oss.oracle.com/licenses/upl.
  */
-/* @@xfail: dtv2 */
 
 /*
- * ASSERTION:
- * 	Positive avg() test
+ * ASSERTION: Positive avg() test
  *
  * SECTION: Aggregations/Aggregations
  *
diff --git a/test/unittest/aggs/tst.avg_neg.d b/test/unittest/aggs/tst.avg_neg.d
index c5e38920..be62b2e2 100644
--- a/test/unittest/aggs/tst.avg_neg.d
+++ b/test/unittest/aggs/tst.avg_neg.d
@@ -4,11 +4,9 @@
  * Licensed under the Universal Permissive License v 1.0 as shown at
  * http://oss.oracle.com/licenses/upl.
  */
-/* @@xfail: dtv2 */
 
 /*
- * ASSERTION:
- *	Positive avg() test using negative values
+ * ASSERTION: Positive avg() test using negative values
  *
  * SECTION: Aggregations/Aggregations
  *
diff --git a/test/unittest/aggs/tst.llquantincr.d b/test/unittest/aggs/tst.llquantincr.d
index 18ed9320..8bc3113c 100644
--- a/test/unittest/aggs/tst.llquantincr.d
+++ b/test/unittest/aggs/tst.llquantincr.d
@@ -4,14 +4,11 @@
  * Licensed under the Universal Permissive License v 1.0 as shown at
  * http://oss.oracle.com/licenses/upl.
  */
-/* @@xfail: dtv2 */
 
 /*
- * ASSERTION:
- *  Optional increment parameter to llquantize() functions correctly.
+ * ASSERTION: Optional increment parameter to llquantize() functions correctly.
  *
  * SECTION: Aggregations/Aggregations
- *
  */
 
 #pragma D option quiet
diff --git a/test/unittest/aggs/tst.llquantize.d b/test/unittest/aggs/tst.llquantize.d
index fe49df61..0080abe3 100644
--- a/test/unittest/aggs/tst.llquantize.d
+++ b/test/unittest/aggs/tst.llquantize.d
@@ -4,14 +4,11 @@
  * Licensed under the Universal Permissive License v 1.0 as shown at
  * http://oss.oracle.com/licenses/upl.
  */
-/* @@xfail: dtv2 */
 
 /*
- * ASSERTION:
- *  Positive llquantize() test
+ * ASSERTION: Positive llquantize() test
  *
  * SECTION: Aggregations/Aggregations
- *
  */
 
 #pragma D option quiet
diff --git a/test/unittest/aggs/tst.llquantneg.d b/test/unittest/aggs/tst.llquantneg.d
index 2587fa2d..3c69839c 100644
--- a/test/unittest/aggs/tst.llquantneg.d
+++ b/test/unittest/aggs/tst.llquantneg.d
@@ -4,14 +4,11 @@
  * Licensed under the Universal Permissive License v 1.0 as shown at
  * http://oss.oracle.com/licenses/upl.
  */
-/* @@xfail: dtv2 */
 
 /*
- * ASSERTION:
- *  llquantize() handles a negative increment correctly.
+ * ASSERTION: llquantize() handles a negative increment correctly.
  *
  * SECTION: Aggregations/Aggregations
- *
  */
 
 #pragma D option quiet
diff --git a/test/unittest/aggs/tst.llquantoverflow.d b/test/unittest/aggs/tst.llquantoverflow.d
index 393969b4..cef207cb 100644
--- a/test/unittest/aggs/tst.llquantoverflow.d
+++ b/test/unittest/aggs/tst.llquantoverflow.d
@@ -4,14 +4,11 @@
  * Licensed under the Universal Permissive License v 1.0 as shown at
  * http://oss.oracle.com/licenses/upl.
  */
-/* @@xfail: dtv2 */
 
 /*
- * ASSERTION:
- *  Values that exceed 32 bits don't overflow.
+ * ASSERTION: Values that exceed 32 bits don't overflow.
  *
  * SECTION: Aggregations/Aggregations
- *
  */
 
 #pragma D option quiet
diff --git a/test/unittest/aggs/tst.llquantround.d b/test/unittest/aggs/tst.llquantround.d
index 8121b372..f2c09676 100644
--- a/test/unittest/aggs/tst.llquantround.d
+++ b/test/unittest/aggs/tst.llquantround.d
@@ -4,7 +4,6 @@
  * Licensed under the Universal Permissive License v 1.0 as shown at
  * http://oss.oracle.com/licenses/upl.
  */
-/* @@xfail: dtv2 */
 
 /*
  * ASSERTION:
@@ -12,7 +11,6 @@
  *  not truncated integer arithmetic.
  *
  * SECTION: Aggregations/Aggregations
- *
  */
 
 #pragma D option quiet
diff --git a/test/unittest/aggs/tst.max.d b/test/unittest/aggs/tst.max.d
index fbd7a31c..76e52c96 100644
--- a/test/unittest/aggs/tst.max.d
+++ b/test/unittest/aggs/tst.max.d
@@ -4,16 +4,13 @@
  * Licensed under the Universal Permissive License v 1.0 as shown at
  * http://oss.oracle.com/licenses/upl.
  */
-/* @@xfail: dtv2 */
 
 /*
- * ASSERTION:
- * 	Positive max() test
+ * ASSERTION: Positive max() test
  *
  * SECTION: Aggregations/Aggregations
  *
  * NOTES: This is verifiable simple positive test of the max() function.
- *
  */
 
 #pragma D option quiet
diff --git a/test/unittest/aggs/tst.max_neg.d b/test/unittest/aggs/tst.max_neg.d
index 8fc4c223..56d29475 100644
--- a/test/unittest/aggs/tst.max_neg.d
+++ b/test/unittest/aggs/tst.max_neg.d
@@ -4,16 +4,13 @@
  * Licensed under the Universal Permissive License v 1.0 as shown at
  * http://oss.oracle.com/licenses/upl.
  */
-/* @@xfail: dtv2 */
 
 /*
- * ASSERTION:
- *	Positive max() test using negative values
+ * ASSERTION: Positive max() test using negative values
  *
  * SECTION: Aggregations/Aggregations
  *
  * NOTES: This is verifiable simple positive test of the max() function.
- *
  */
 
 #pragma D option quiet
diff --git a/test/unittest/aggs/tst.min.d b/test/unittest/aggs/tst.min.d
index e1e4e30c..60b4fdd6 100644
--- a/test/unittest/aggs/tst.min.d
+++ b/test/unittest/aggs/tst.min.d
@@ -4,16 +4,13 @@
  * Licensed under the Universal Permissive License v 1.0 as shown at
  * http://oss.oracle.com/licenses/upl.
  */
-/* @@xfail: dtv2 */
 
 /*
- * ASSERTION:
- * 	Positive min() test
+ * ASSERTION: Positive min() test
  *
  * SECTION: Aggregations/Aggregations
  *
  * NOTES: This is verifiable simple positive test of the min() function.
- *
  */
 
 #pragma D option quiet
diff --git a/test/unittest/aggs/tst.min_neg.d b/test/unittest/aggs/tst.min_neg.d
index d88b6fdb..b01689f0 100644
--- a/test/unittest/aggs/tst.min_neg.d
+++ b/test/unittest/aggs/tst.min_neg.d
@@ -4,16 +4,13 @@
  * Licensed under the Universal Permissive License v 1.0 as shown at
  * http://oss.oracle.com/licenses/upl.
  */
-/* @@xfail: dtv2 */
 
 /*
- * ASSERTION:
- *      Positive min() test using negative values
+ * ASSERTION: Positive min() test using negative values
  *
  * SECTION: Aggregations/Aggregations
  *
  * NOTES: This is verifiable simple positive test of the min() function.
- *
  */
 
 #pragma D option quiet
diff --git a/test/unittest/aggs/tst.multiaggs2.d b/test/unittest/aggs/tst.multiaggs2.d
index 38bea3d6..b396de00 100644
--- a/test/unittest/aggs/tst.multiaggs2.d
+++ b/test/unittest/aggs/tst.multiaggs2.d
@@ -4,15 +4,12 @@
  * Licensed under the Universal Permissive License v 1.0 as shown at
  * http://oss.oracle.com/licenses/upl.
  */
-/* @@xfail: dtv2 */
 
 /*
- * ASSERTION:
- *   Test multiple aggregations and the default output order
+ * ASSERTION: Test multiple aggregations and the default output order
  *
  * SECTION: Aggregations/Aggregations;
  *	Aggregations/Output
- *
  */
 
 #pragma D option quiet
diff --git a/test/unittest/aggs/tst.quantlast.d b/test/unittest/aggs/tst.quantlast.d
index ae74f1a9..a3c25a0b 100644
--- a/test/unittest/aggs/tst.quantlast.d
+++ b/test/unittest/aggs/tst.quantlast.d
@@ -4,14 +4,11 @@
  * Licensed under the Universal Permissive License v 1.0 as shown at
  * http://oss.oracle.com/licenses/upl.
  */
-/* @@xfail: dtv2 */
 
 /*
- * ASSERTION:
- * 	Data exclusively in the last bin is correctly reported.
+ * ASSERTION: Data exclusively in the last bin is correctly reported.
  *
  * SECTION: Aggregations/Aggregations
- *
  */
 
 #pragma D option quiet
diff --git a/test/unittest/aggs/tst.quantround.d b/test/unittest/aggs/tst.quantround.d
index c75f28c9..863011f9 100644
--- a/test/unittest/aggs/tst.quantround.d
+++ b/test/unittest/aggs/tst.quantround.d
@@ -4,7 +4,6 @@
  * Licensed under the Universal Permissive License v 1.0 as shown at
  * http://oss.oracle.com/licenses/upl.
  */
-/* @@xfail: dtv2 */
 
 #pragma D option quiet
 
diff --git a/test/unittest/aggs/tst.stddev.d b/test/unittest/aggs/tst.stddev.d
index b5946b37..f506ed0c 100644
--- a/test/unittest/aggs/tst.stddev.d
+++ b/test/unittest/aggs/tst.stddev.d
@@ -4,11 +4,9 @@
  * Licensed under the Universal Permissive License v 1.0 as shown at
  * http://oss.oracle.com/licenses/upl.
  */
-/* @@xfail: dtv2 */
 
 /*
- * ASSERTION:
- *      Positive stddev() test
+ * ASSERTION: Positive stddev() test
  *
  * SECTION: Aggregations/Aggregations
  *
diff --git a/test/unittest/aggs/tst.sum.d b/test/unittest/aggs/tst.sum.d
index e7ee8801..6ad4f36d 100644
--- a/test/unittest/aggs/tst.sum.d
+++ b/test/unittest/aggs/tst.sum.d
@@ -4,11 +4,9 @@
  * Licensed under the Universal Permissive License v 1.0 as shown at
  * http://oss.oracle.com/licenses/upl.
  */
-/* @@xfail: dtv2 */
 
 /*
- * ASSERTION:
- * 	Positive sum() test
+ * ASSERTION: Positive sum() test
  *
  * SECTION: Aggregations/Aggregations
  *
diff --git a/test/unittest/printa/tst.walltimestamp.sh b/test/unittest/printa/tst.walltimestamp.sh
index 1c290124..f2d05b0c 100755
--- a/test/unittest/printa/tst.walltimestamp.sh
+++ b/test/unittest/printa/tst.walltimestamp.sh
@@ -9,7 +9,6 @@ if [ $# != 1 ]; then
 	echo expected one argument: '<'dtrace-path'>'
 	exit 2
 fi
-# @@xfail: dtv2
 
 dtrace=$1
 
-- 
2.28.0




More information about the DTrace-devel mailing list