[DTrace-devel] [PATCH] Implementation of the printa() action

[Kris Van Hees]

On Tue, Dec 08, 2020 at 04:59:51PM -0500, Kris Van Hees wrote:
> On Tue, Dec 08, 2020 at 01:34:16PM -0800, Eugene Loh wrote:
> > On 12/07/2020 01:07 PM, Kris Van Hees wrote:
> > 
> > > Given the design for the handling of aggregation data, there is no
> > > further need for cummulative data retrieval using snapshots.  When we
> > > are ready to display aggregation data, we can retrieve the data by
> > > performing a key 0 BPF map lookup on the 'aggs' map.  It gives us all
> > > data for all CPUs in a single buffer.
> > 
> > I'm trying to review this, but the patch is big and covers a lot of code 
> > that's unfamiliar to me.  Here are some preliminary comments. They 
> > aren't meant to be important, but only what I've gotten to so far.
> > 
> > These "new" tests have 2006 (-2020) copyrights.
> >      test/unittest/actions/printa/err.D_PRINTA_PROTO.fmt_no_arg.d
> >      test/unittest/actions/printa/err.D_PROTO_LEN.no_arg.d
> >      test/unittest/aggs/err.D_AGG_REDEF.idx_diff_funcs.d
> 
> Thanks.  Corrected in my copy.

Actually, not being changed because those tests are pre-existing tests under
a new name (and location).  So, the content is indeed copyright 2006, 2020.