[DTrace-devel] [PATCH 10/13] Eliminate duplicate test
Kris Van Hees
kris.van.hees at oracle.com
Tue Dec 8 11:06:51 PST 2020
This patch content has already been captured in other patches. Thanks for
pointing them out though, and indeed it is a fine example of how some tests
just don't have names that make sense.
On Wed, Dec 02, 2020 at 01:54:55PM -0500, eugene.loh at oracle.com wrote:
> From: Eugene Loh <eugene.loh at oracle.com>
>
> In test/unittest/aggs, the two tests
> err.D_LQUANT_BASETYPE.lqbad1.d
> err.D_LQUANT_BASETYPE.lqshort.d
> are exactly identical. The only difference is that the name of the
> second one makes no sense. Eliminate that second file.
>
> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
> Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>
> ---
> .../aggs/err.D_LQUANT_BASETYPE.lqshort.d | 23 -------------------
> 1 file changed, 23 deletions(-)
> delete mode 100644 test/unittest/aggs/err.D_LQUANT_BASETYPE.lqshort.d
>
> diff --git a/test/unittest/aggs/err.D_LQUANT_BASETYPE.lqshort.d b/test/unittest/aggs/err.D_LQUANT_BASETYPE.lqshort.d
> deleted file mode 100644
> index 3dc570b4..00000000
> --- a/test/unittest/aggs/err.D_LQUANT_BASETYPE.lqshort.d
> +++ /dev/null
> @@ -1,23 +0,0 @@
> -/*
> - * Oracle Linux DTrace.
> - * Copyright (c) 2006, Oracle and/or its affiliates. All rights reserved.
> - * Licensed under the Universal Permissive License v 1.0 as shown at
> - * http://oss.oracle.com/licenses/upl.
> - */
> -/* @@xfail: dtv2 */
> -
> -/*
> - * ASSERTION:
> - * lquantize() lower bound around must be an integer constant
> - *
> - * SECTION: Aggregations/Aggregations
> - *
> - */
> -
> -
> -BEGIN
> -{
> - x = 'a';
> - @a[1] = lquantize(timestamp, x, 1000, 1);
> -}
> -
> --
> 2.18.4
>
>
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel
More information about the DTrace-devel
mailing list