[DTrace-devel] [PATCH] Disable the printing of aggregations

[Eugene Loh]

lgtm


On 04/08/2020 08:00 AM, Kris Van Hees wrote:
> Since aggregations are not supported yet in DTrace v2, and now that it
> is possible to use the exit() action to end tracing, the auto-printing
> of aggregations when tracing ends is commented out pending a working
> implementation of aggregations.
>
> Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
> ---
>   cmd/dtrace.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/cmd/dtrace.c b/cmd/dtrace.c
> index 20448ae4..f4d65f78 100644
> --- a/cmd/dtrace.c
> +++ b/cmd/dtrace.c
> @@ -1541,11 +1541,13 @@ main(int argc, char *argv[])
>   
>   	oprintf("\n");
>   
> +#if 0
>   	if (!g_impatient) {
>   		if (dtrace_aggregate_print(g_dtp, g_ofp, NULL) == -1 &&
>   		    dtrace_errno(g_dtp) != EINTR)
>   			dfatal("failed to print aggregations");
>   	}
> +#endif
>   
>   	for (i = 0; i < g_psc; i++)
>   		dtrace_proc_release(g_dtp, g_psv[i]);