[PATCH 0 of 2] Trivial fixes

Zach Brown zach.brown at oracle.com
Mon Mar 24 11:02:41 PDT 2008


Brandon Philips wrote:
> Hello-
> 
> Trivial fixes follow.  :D

Awesome, thanks ;).

> The printf fixes were required to get crfs to compile (since warnings are
> errors) on my system (Debian Unstable, gcc 4.2.3).

I committed the iov_len fixes as you sent them.  They're fine for now.
I think they'll break OSX, as I kind of remember it having a weird
iov_len type.  But getting crfsd building in OSX is going to be a treat
for many more fundamental reasons ;).

I did the config file size fixes a little differently.  I had it check
that the file size wasn't crazy and then just stored it in an unsigned
int while we worked on it.  That seemed easier.

> Also, the crfs/docs/developer-tutorial file that the website references doesn't
> exist.  I guess it should be developer-instructions instead.

Oops.  Thanks, I fixed that.  I also committed your fixes to the file
itself.

- z



More information about the crfs-devel mailing list