Missing 'h' and '?' in geopt's arg in crfsd.c

Zhu Yanhai piggestpig at gmail.com
Fri Mar 21 23:34:09 PDT 2008


Hello,
  There should be a 'h' and '?' in getopt's arg list in crfsd.c
  I can't connect to oss.oracle.com temporarily, so below patch is not
based on the latest version, sorry.

-
Regards,
Zhu Yanhai

--
diff -r 4feb9a35e437 crfsd/crfsd.c
--- a/crfsd/crfsd.c	Wed Mar 12 11:43:39 2008 -0700
+++ b/crfsd/crfsd.c	Sat Mar 22 12:04:55 2008 +0800
@@ -127,7 +127,7 @@ int main(int argc, char **argv)
 	sigaction(SIGTERM, &sa, NULL);

 	while(1) {
-		c = getopt(argc, argv, "+c:");
+		c = getopt(argc, argv, "+c:h?");
 		if (c == -1)
 			break;

@@ -136,9 +136,9 @@ int main(int argc, char **argv)
 				config = strdup(optarg);
 				break;
 			case 'h':
+			case '?':	
 				usage(NULL);
 				goto out;
-			case '?':
 			default:
 				usage("unknown option\n");
 				break;



More information about the crfs-devel mailing list