[Btrfs-devel] [PATCH 2/4] supporting code to add xattr support

[Zach Brown]

> +
> +int btrfs_insert_xattr_item(struct btrfs_trans_handle *trans,
> +			    struct btrfs_root *root, const char *name,
> +			    int name_len, const void *data, int data_len,

I bet those _lens can never be negative.  They shouldn't be 'int's.
(types that don't reflect the intended range of values is a pet peeve of
mine :)).  u32 is probably most appropriate, given that they're being
jammed into data_size?

- z