[Btrfs-devel][PATCH]Properly delete csum item in btrfs_truncate_in_trans.

Yan Zheng yanzheng at 21cn.com
Tue Nov 6 07:59:42 PST 2007


Hello,

When 'item_end' is equal to 'inode->i_size',   'found_type' is updated
and current item is skipped. This behavior is correct for extent item,
but incorrect for csum item. For example, there is a csum item with
'offset == 0'. When deleting the inode,  'inode->i_size' is set to 0,
so the csum item isn't deleted.

Regards
YZ
---
diff -r 2456df534a5f inode.c
--- a/inode.c	Thu Nov 01 19:45:34 2007 -0400
+++ b/inode.c	Tue Nov 06 23:29:40 2007 +0800
@@ -611,13 +611,14 @@ static int btrfs_truncate_in_trans(struc
 				item_end += btrfs_file_extent_inline_len(leaf,
 									 item);
 			}
+			item_end--;
 		}
 		if (found_type == BTRFS_CSUM_ITEM_KEY) {
 			ret = btrfs_csum_truncate(trans, root, path,
 						  inode->i_size);
 			BUG_ON(ret);
 		}
-		if (item_end <= inode->i_size) {
+		if (item_end < inode->i_size) {
 			if (found_type == BTRFS_DIR_ITEM_KEY) {
 				found_type = BTRFS_INODE_ITEM_KEY;
 			} else if (found_type == BTRFS_EXTENT_ITEM_KEY) {



More information about the Btrfs-devel mailing list