Hi,<div><br></div><div>I don't seem able to get a library with the functions exposed using this method. Can you share your compiled version so I can try linking Chromium with it? Just trying to get a working copy because there's quite some work I need to do on the CrOS side being blocked by this at the moment, and the March 15th deadline is looming. I'm also away this next week, which is quite unfortunate. :/</div>
<div><br></div><div>If you could tar up your /usr/local/Berkleysomething directory and attach it, that'd be super.</div><div><br></div><div>Thanks,</div><div>Liam<br><br><div class="gmail_quote">On 4 March 2010 20:41, Sandra Whitman <span dir="ltr"><<a href="mailto:sandra.whitman@oracle.com">sandra.whitman@oracle.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Hi Liam,<br>
<br>
<br>
I did not use the patch from Alex, as I had earlier in the day applied the Chromium patches using the hints Greg mentioned. The steps I followed are below. Apologies on any confusion here. I am still working on building the fts2/Chromium support. I do see fts2/Chromium in the library I built and fts2 works at a very basic level which I tested, but as Alex explained to me last evening, I did not build in a supported way, so I need to still determine how to correctly do that. <br>
<br>
For the patches, according to the instructions at:<br>
<a href="http://src.chromium.org/cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD" target="_blank">http://src.chromium.org/cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD</a><br>
<br>
they should be applied as:<br>
<br>
cd db-5.0.11/sql/sqlite<br>
patch -p0 < misc.patch // see below<br>
patch -p0 < preload-cache.patch // see below<br>
patch -p0 < safe-tolower.patch // applied changes manually<br>
patch -p0 < sqlite-poison.patch // don't apply<br>
patch -p0 < fts2.patch // applies fine<br>
patch -p0 < icu-regexp.patch // applies fine<br>
<br>
<br>
According to Greg we don't need to apply sqlite-poison.patch, so I did not do that. He also suggested applying the changes manually from safe-tolower.patch and I did that as well.<br>
<br>
For the misc.patch there are a bunch of small configuration settings and other minor changes, all easily integrated some already in our tree. I skipped the part of the patch removing the ifdef around sqlite3PcacheGetCachesize() because it's not used in our (empty) version of the sqlite3Preload() call (above). With that change this patch applied without errors.<br>
<br>
<br>
For preload-cache.patch I manually replaced the sqlite3Preload function in<br>
db-5.0.11/sql/sqlite/src/build.c with an empty function i.e.:<div class="im"><br>
int sqlite3Preload(sqlite3 *db) { return SQLITE_OK; }<br></div>
as per the suggestion from Greg.<br>
<br>
<br>
So my db-5.0.11/sql/sqlite/src/build.c contains:<br>
<br>
/* Begin preload-cache.patch for Chromium */<br>
/* See declaration in sqlite3.h for information */<br>
// edits for Chromium preload-cache.patch<div class="im"><br>
int sqlite3Preload(sqlite3 *db)<br>
{<br>
return SQLITE_OK;<br>
}<br></div>
/* End preload-cache.patch for Chromium */<br>
<br>
<br>
Let me know if this does not help. Again, I do apologize for any confusion, I will try to get the exact sequence of events worked out and then send them along.<br>
<br>
<br>
Thanks,<br>
Sandra<br>
<br>
<br>
Hexxeh wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">
Hi,<br>
<br>
Just tried applying that patch, compile failed:<br>
<br>
../dist/../sql/generated/sqlite3.c:64603: error: duplicate member 'preload'<br>
<br>
Sandra: Can you share your compiled copy so I can try building against that on Chromium?<br>
<br>
Thanks,<br>
Liam<br>
<br></div><div><div></div><div class="h5">
On 4 March 2010 02:13, Alex Gorrod <<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a> <mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>> wrote:<br>
<br>
Hi Sandra,<br>
<br>
When you do "cd build_unix/sql && make" you are building from a<br>
different version of the source, than doing "cd build_unix &&<br>
make". The first does not use the amalgamated source, the second does.<br>
<br>
I think that's probably why you're seeing different behavior. It's<br>
best to avoid building directly from the build_unix/sql directory<br>
(since it's only really used for test builds).<br>
<br>
I'd recommend the process being:<br>
<br>
$ tar zxvf db-5.0.11.tar.gz<br>
<br>
$ cd db-5.0.11<br>
$ chmod 555 sql/sqlite/configure<br>
$ patch -p1 < all_my_differences.diff<br>
$ cd dist<br>
$ ./s_sql<br>
(say yes to any permission related questions)<br>
$ cd ../build_unix<br>
$ ../dist/configure --enable-sql_compat<br>
$ make<br>
<br>
I've poked at this a bit, and I'm surprised the original patch<br>
exposes the API publicly. It seems that any function that begins<br>
with "sqlite3_" is automatically marked SQLITE_API, others are<br>
SQLITE_PRIVATE.<br>
<br>
The attached patch adds an empty sqlite3_preload API, but I can't<br>
see how to get the auto-generated code to have a public API called<br>
sqlite3Preload.<br>
<br>
If you applied the patch attached to this email at the<br>
all_my_differences step, you can run (from the build_unix directory):<br>
$ nm .libs/libsqlite3.so | grep preload<br>
0025d00 T sqlite3_preload<br>
$ ./sqlite3<br>
dbsql> .quit<br>
<br>
(The patch added a call to sqlite3_preload to the shell utility,<br>
so the API is available).<br>
<br>
- Alex<br>
<br>
<br>
On 4/03/2010 11:37 AM, Sandra Whitman wrote:<br>
<br>
Hi Alex,<br>
<br>
I did not change the SQLITE_PRIVATE but I am seeing:<br>
<br>
nm libsqlite3.so | grep sqlite3Preload<br>
00019fa0 T sqlite3Preload<br>
<br>
I still have one other problem in that sqlite_shell_init_icu<br>
added by<br>
one of the Chromium patches, in shell.c,<br>
is unresolved. I'm working on that.<br>
<br>
However this is how I built libsqlite3.so. Does this sound right?<br>
// generate the amalgamated code<br>
$ cd db-5.0.11/dist<br>
$ chmod 555 ../sql/sqlite/configure<br>
$ ./s_sql<br>
<br>
// build, maybe configured for --enable-sql<br>
$ cd build_unix<br>
$ make<br>
<br>
// build libsqlite3.so from build_unix/sql directory<br>
cd build_unix/sql<br>
edit the Makefile to link with /build_unix/.libs/<a href="http://libdb-5.0.so" target="_blank">libdb-5.0.so</a><br></div></div>
<<a href="http://libdb-5.0.so" target="_blank">http://libdb-5.0.so</a>><div><div></div><div class="h5"><br>
make<br>
<br>
This includes the fts2 files and other Chromium patches<br>
previously set.<br>
<br>
Thanks,<br>
Sandra<br>
<br>
<br>
<br>
<br>
Alex Gorrod wrote:<br>
<br>
Hi,<br>
<br>
It probably is - SQLITE_PRIVATE marks functions as static.<br>
Changing<br>
SQLITE_PRIVATE to SQLITE_API is the right thing to do.<br>
<br>
It looks like you need to add an entry to<br>
sql/sqlite/src/sqlite3ext.h<br>
to have the API marked SQLITE_API. I'm figuring out the<br>
syntax for that.<br>
<br>
Sandra: Did you get this to work? If so, could you send a<br>
patch that<br>
shows the differences in your db tree to the release?<br>
<br>
- Alex<br>
<br>
On 4/03/2010 10:59 AM, Hexxeh wrote:<br>
<br>
Hi,<br>
<br>
They're in, but as SQLITE_PRIVATE, could this be the<br>
problem?<br>
<br>
Regards,<br>
Liam<br>
<br>
On 3 March 2010 23:56, Alex Gorrod<br>
<<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br></div></div><div class="im">
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>> wrote:<br>
<br>
Hi,<br>
<br>
<br></div><div><div></div><div class="h5">
On 4/03/2010 10:39 AM, Hexxeh wrote:<br>
<br>
Just tried make clean and then make, still can't see<br>
the preload<br>
function in the strings. This is most puzzling, it<br>
would seem.<br>
Have you<br>
been able to compile this dummy function in? I may well be<br>
making some<br>
silly mistake and not noticing.<br>
<br>
<br>
:( Could you look in sql/generated/sqlite3.c, and see<br>
if the preload<br>
function is in there?<br>
<br>
If it's not, could you remove that file, and try<br>
re-running dist/s_sql?<br>
<br>
I have not built it with the change so far. I'll do<br>
that now, and<br>
let you know what I find.<br>
<br>
- Alex<br>
<br>
Sandra: If you can get that build working, I should<br>
just be able<br>
to copy<br>
the .a, .la and .so files across to link against them,<br>
I think?<br>
Thanks<br>
for your help on this both, by the way! :)<br>
<br>
Regards,<br>
Liam<br>
<br>
On 3 March 2010 23:19, Alex Gorrod<br>
<<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br></div></div><div><div></div><div class="h5">
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>>> wrote:<br>
<br>
Hi,<br>
<br>
I'm running a bit low on ideas here..<br>
<br>
<br>
On 4/03/2010 9:46 AM, Hexxeh wrote:<br>
<br>
env CFLAGS="-O3" ../dist/configure --enable-sql_compat<br>
--enable-sql<br>
make dbsql && sudo make install<br>
<br>
<br>
Does anything else get rebuilt when you just run "make",<br>
"dbsql" is<br>
the name of the shell component? Otherwise (due to the<br>
way our<br>
makefile is setup) changes to header files sometimes<br>
don't get<br>
picked up by gcc. Could you try "make clean" and make (or<br>
removing<br>
the sql related object and lib files if you can pick the<br>
right ones).<br>
<br>
Also, I never introduced myself. My name is Alex - I<br>
work as an<br>
engineer on the Berkeley DB product. I'm currently focused<br>
on the<br>
SQL part of the product.<br>
<br>
I've also cc'ed Sandra from support, as she is going<br>
through the<br>
same process in parallel.<br>
<br>
- Alex<br>
<br>
<br>
And then checked the outputted library in .libs<br>
<br>
Regards,<br>
Liam<br>
<br>
On 3 March 2010 22:44, Alex Gorrod<br>
<<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>><br></div></div><div><div></div><div class="h5">
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>>>> wrote:<br>
<br>
Hi,<br>
<br>
To be sure, those steps did not include rebuilding<br>
the library<br>
(sorry), just re-generating the files needed for the<br>
build.<br>
Did you<br>
also rebuild?<br>
<br>
- Alex<br>
<br>
<br>
On 4/03/2010 9:41 AM, Hexxeh wrote:<br>
<br>
Hi,<br>
<br>
Okay, well those steps ran just fine, however<br>
the same<br>
issue remains<br>
when checking the outputted library with strings?<br>
<br>
Regards,<br>
Liam<br>
<br>
On 3 March 2010 22:34, Alex Gorrod<br>
<<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>>><br></div></div><div><div></div><div class="h5">
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>>>>> wrote:<br>
<br>
Hi,<br>
<br>
:( It's something else. Please do:<br>
<br>
$ chmod 555 db-5.0.11/sql/sqlite/configure<br>
<br>
We need to set executable permissions in the<br>
package, I'll<br>
make sure<br>
that's fixed in the next release.<br>
<br>
- Alex<br>
<br>
<br>
On 4/03/2010 9:31 AM, Hexxeh wrote:<br>
<br>
Hi,<br>
<br>
Just gave that a shot and got a bunch of<br>
errors:<br>
<br>
hexxeh@oxygen:~/bdb5/db-5.0.11/dist$ ./s_sql<br>
./s_sql: line 27:<br>
/home/hexxeh/bdb5/db-5.0.11/sql/sqlite/configure:<br>
Permission denied<br>
make: *** No rule to make target<br>
`sqlite3.c'. Stop.<br>
cp: cannot stat `sqlite3.c': No such file or<br>
directory<br>
cp: cannot stat `sqlite3.h': No such file or<br>
directory<br>
cp: cannot stat `keywordhash.h': No such<br>
file or<br>
directory<br>
cp: cannot stat `opcodes.c': No such file or<br>
directory<br>
cp: cannot stat `opcodes.h': No such file or<br>
directory<br>
cp: cannot stat `parse.c': No such file<br>
or directory<br>
cp: cannot stat `parse.h': No such file<br>
or directory<br>
<br>
Worth unpacking a fresh copy and<br>
reapplying the<br>
changes<br>
or is this<br>
something else?<br>
<br>
Regards,<br>
Liam<br>
<br>
On 3 March 2010 22:23, Alex Gorrod<br>
<<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>>>><br></div></div><div><div></div><div class="h5">
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>>>>>> wrote:<br>
<br>
Hi,<br>
<br></div></div><div><div></div><div class="h5">
Those look like the correct places<br>
to add<br>
the code.<br>
You'll<br>
probably<br>
need two additional steps:<br>
<br>
1) Run a script from the<br>
"db-5.0.XX/dist"<br>
directory,<br>
called<br>
"s_sql".<br>
Like:<br>
$ cd db-5.0.11/dist<br>
$ ./s_sql<br>
This step generates the equivalent<br>
to the SQLite<br>
amalgamated<br>
source<br>
file. You need to have a shell<br>
prompt (not a DOS<br>
prompt),<br>
and have<br>
Tcl installed.<br>
2) Re-run configure. Since you're<br>
changing a<br>
header.<br>
This<br>
might not<br>
be necessary, but won't hurt.<br>
<br>
- Alex<br>
<br>
<br>
On 4/03/2010 9:14 AM, Hexxeh wrote:<br>
<br>
Hi,<br>
<br>
I'll take a look at those in a<br>
second.<br>
Made the<br>
change<br>
regarding the<br>
preload function, however, when I<br>
rebuild the<br>
library, it<br>
doesn't appear<br>
to be going into it? Running strings<br>
libsqlite3.so |<br>
grep sqlite<br>
doesn't<br>
show the function name, but does<br>
show many<br>
others; and<br>
the Chromium<br>
compile process doesn't think<br>
it's there<br>
either.<br>
<br>
I added the prototype into<br>
sql/sqlite/src/<a href="http://sqlite.h.in" target="_blank">sqlite.h.in</a> <<a href="http://sqlite.h.in" target="_blank">http://sqlite.h.in</a>><br>
<<a href="http://sqlite.h.in" target="_blank">http://sqlite.h.in</a>><br>
<<a href="http://sqlite.h.in" target="_blank">http://sqlite.h.in</a>><br>
<<a href="http://sqlite.h.in" target="_blank">http://sqlite.h.in</a>><br>
<<a href="http://sqlite.h.in" target="_blank">http://sqlite.h.in</a>><br>
<<a href="http://sqlite.h.in" target="_blank">http://sqlite.h.in</a>><br>
<<a href="http://sqlite.h.in" target="_blank">http://sqlite.h.in</a>> and the declaration into<br>
sql/sqlite/src/global.c:<br>
<br>
is this correct?<br>
<br>
Regards,<br>
Liam<br>
<br>
On 3 March 2010 21:52, Alex Gorrod<br>
<<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>>>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a><br>
<mailto:<a href="mailto:alexander.gorrod@oracle.com" target="_blank">alexander.gorrod@oracle.com</a>>>>>>>>> wrote:<br>
<br>
Hi,<br>
<br>
<br>
On 4/03/2010 3:07 AM, Hexxeh<br>
wrote:<br>
<br>
I think the other problem<br>
encountered in the<br>
build was these<br>
functions<br>
that haven't been exposed:<br>
<br>
- Exposed three<br>
functions that<br>
deal with<br>
unused file<br>
descriptors in<br>
152<br>
</cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l152><br>
<br>
<br>
os_unix.c, to allow<br>
Chromium's Posix VFS<br>
implementation in<br>
153<br>
</cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l153><br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
WebKit/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp<br>
154<br>
</cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l154><br>
<br>
<br>
to correctly<br>
implement the<br>
"unused file<br>
descriptors"<br>
logic<br>
in the<br>
155<br>
</cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l155><br>
<br>
<br>
xDlOpen() method.<br>
The new<br>
functions are<br>
156<br>
</cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l156><br>
<br>
<br>
<br>
chromium_sqlite3_get_reusable_file_handle(),<br>
157<br>
</cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l157><br>
<br>
<br>
<br>
<br>
chromium_sqlite3_update_reusable_file_handle() and<br>
158<br>
</cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l158><br>
<br>
<br>
<br>
chromium_sqlite3_destroy_reusable_file_handle().<br>
Also, added the<br>
159<br>
</cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l159><br>
<br>
<br>
<br>
chromium_sqlite3_fill_in_unix_sqlite3_file()<br>
function that calls<br>
160<br>
</cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l160><br>
<br>
<br>
fillInUnixFile(),<br>
which will<br>
be made<br>
static<br>
again as<br>
soon as a<br>
161<br>
</cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l161><br>
<br>
<br>
WebKit patch using<br>
the new<br>
function<br>
lands.<br>
<br>
<br>
Could you clarify what this<br>
patch is<br>
used for<br>
please. I'll<br>
add some<br>
context. Berkeley DB SQL<br>
does not<br>
use the<br>
SQLite VFS<br>
code -<br>
it is<br>
one of the components that<br>
has been<br>
replaced.<br>
<br>
So, if those functions need<br>
to be<br>
exposed so<br>
that<br>
you can<br>
modify the<br>
behavior of SQLite (by<br>
implementing<br>
a custom<br>
VFS),<br>
then your<br>
changes<br>
should no longer be necessary.<br>
<br>
Thanks,<br>
Alex<br>
<br>
<br>
<br>
<br>
<br>
_______________________________________________<br>
BDB-BETA-FEEDBACK mailing list<br>
<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>>>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>>>>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>>>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>>>>>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>>>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>>>>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>>>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a><br>
<mailto:<a href="mailto:BDB-BETA-FEEDBACK@oss.oracle.com" target="_blank">BDB-BETA-FEEDBACK@oss.oracle.com</a>>>>>>><br>
<br>
<a href="http://oss.oracle.com/mailman/listinfo/bdb-beta-feedback" target="_blank">http://oss.oracle.com/mailman/listinfo/bdb-beta-feedback</a><br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
</div></div></blockquote>
</blockquote></div><br></div>