Hi,<div><br></div><div>I'll take a look at those in a second. Made the change regarding the preload function, however, when I rebuild the library, it doesn't appear to be going into it? Running strings libsqlite3.so | grep sqlite doesn't show the function name, but does show many others; and the Chromium compile process doesn't think it's there either. </div>
<div><br></div><div>I added the prototype into sql/sqlite/src/<a href="http://sqlite.h.in">sqlite.h.in</a> and the declaration into sql/sqlite/src/global.c: is this correct?</div><div><br></div><div>Regards,</div><div>Liam<br>
<br><div class="gmail_quote">On 3 March 2010 21:52, Alex Gorrod <span dir="ltr"><<a href="mailto:alexander.gorrod@oracle.com">alexander.gorrod@oracle.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Hi,<div class="im"><br>
<br>
On 4/03/2010 3:07 AM, Hexxeh wrote:<br>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">
I think the other problem encountered in the build was these functions<br>
that haven't been exposed:<br>
<br>
- Exposed three functions that deal with unused file descriptors in<br>
152<br></div>
</cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l152><div class="im"><br>
os_unix.c, to allow Chromium's Posix VFS implementation in<br>
153<br></div>
</cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l153><div class="im"><br>
WebKit/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp<br>
154<br></div>
</cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l154><div class="im"><br>
to correctly implement the "unused file descriptors" logic in the<br>
155<br></div>
</cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l155><div class="im"><br>
xDlOpen() method. The new functions are<br>
156<br></div>
</cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l156><div class="im"><br>
chromium_sqlite3_get_reusable_file_handle(),<br>
157<br></div>
</cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l157><div class="im"><br>
chromium_sqlite3_update_reusable_file_handle() and<br>
158<br></div>
</cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l158><div class="im"><br>
chromium_sqlite3_destroy_reusable_file_handle(). Also, added the<br>
159<br></div>
</cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l159><div class="im"><br>
chromium_sqlite3_fill_in_unix_sqlite3_file() function that calls<br>
160<br></div>
</cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l160><div class="im"><br>
fillInUnixFile(), which will be made static again as soon as a<br>
161<br></div>
</cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=third_party/sqlite/README.chromium;h=6953e64e7bf0c462c10d0c7b84ff0052638f8e46;hb=HEAD#l161><div class="im"><br>
WebKit patch using the new function lands.<br>
</div></blockquote>
<br>
Could you clarify what this patch is used for please. I'll add some context. Berkeley DB SQL does not use the SQLite VFS code - it is one of the components that has been replaced.<br>
<br>
So, if those functions need to be exposed so that you can modify the behavior of SQLite (by implementing a custom VFS), then your changes should no longer be necessary.<br>
<br>
Thanks,<br><font color="#888888">
Alex<br>
</font></blockquote></div><br></div>